Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusion between 1-based Buffer and 0-based index #7825

Closed
wants to merge 1 commit into from

Conversation

hlinnaka
Copy link
Contributor

The code was working correctly, but was incorrectly using Buffer for a 0-based index into the BufferDesc array.

@hlinnaka hlinnaka requested review from a team as code owners May 21, 2024 16:42
Copy link

github-actions bot commented May 21, 2024

3096 tests run: 2969 passed, 0 failed, 127 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_crafted_wal_end[last_wal_record_xlog_switch_ends_on_page_boundary]: release

Postgres 15

  • test_ancestor_detach_reparents_earlier: debug

Postgres 14

  • test_download_remote_layers_api: debug

Code coverage* (full report)

  • functions: 31.3% (6414 of 20481 functions)
  • lines: 48.0% (49312 of 102647 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0aa9549 at 2024-05-22T12:38:29.056Z :recycle:

The code was working correctly, but was incorrectly using Buffer for a
0-based index into the BufferDesc array.
hlinnaka added a commit that referenced this pull request May 22, 2024
The code was working correctly, but was incorrectly using Buffer for a
0-based index into the BufferDesc array.
@hlinnaka
Copy link
Contributor Author

Was committed as commit 3404e76

@hlinnaka hlinnaka closed this May 22, 2024
@hlinnaka hlinnaka deleted the tidy-Buffer-confusion branch May 22, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant