Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Adjust retry wake compute #7537

Merged
merged 1 commit into from
Apr 29, 2024
Merged

proxy: Adjust retry wake compute #7537

merged 1 commit into from
Apr 29, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Apr 29, 2024

Problem

Right now we always do retry wake compute.

Summary of changes

Create a list of errors when we could avoid needless retries.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner April 29, 2024 10:24
Copy link
Contributor

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct. Just to confirm, this will exit early for any non recoverable connection errors?

@khanova khanova enabled auto-merge (squash) April 29, 2024 10:45
Copy link

github-actions bot commented Apr 29, 2024

2844 tests run: 2721 passed, 2 failed, 121 skipped (full report)


Failures on Postgres 15

  • test_sharding_split_failures[failure20]: debug
  • test_sharding_split_failures[failure3]: debug
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharding_split_failures[debug-pg15-failure20] or test_sharding_split_failures[debug-pg15-failure3]"
Flaky tests (1)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 28.2% (6552 of 23265 functions)
  • lines: 46.8% (46283 of 98843 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c7bd800 at 2024-04-29T12:33:58.992Z :recycle:

@khanova khanova merged commit 90cadfa into main Apr 29, 2024
53 checks passed
@khanova khanova deleted the proxy-retry-wake-compute branch April 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants