Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(virtual_file): compile warnings on macos #7525

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix(virtual_file): compile warnings on macos #7525

merged 1 commit into from
Apr 26, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Apr 26, 2024

Problem

starting at commit dbb0c96, macOS reports warning for a few functions in the virtual file module.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from problame April 26, 2024 17:58
@skyzh skyzh requested a review from a team as a code owner April 26, 2024 17:58
Copy link

github-actions bot commented Apr 26, 2024

2820 tests run: 2698 passed, 1 failed, 121 skipped (full report)


Failures on Postgres 15

  • test_sharding_split_failures[failure10]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharding_split_failures[release-pg15-failure10]"

Code coverage* (full report)

  • functions: 28.3% (6547 of 23143 functions)
  • lines: 47.0% (46235 of 98460 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
fa16e98 at 2024-04-26T19:22:04.983Z :recycle:

@skyzh skyzh merged commit 75b4440 into main Apr 26, 2024
53 of 54 checks passed
@skyzh skyzh deleted the skyzh/fix-warning branch April 26, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants