Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Past instead of Present or Future when commit_lsn < min_lsn #7520

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Apr 26, 2024

Implements an approach different from the one #7488 chose: We now return past instead of present (orfuture) when encountering the edge case where commit_lsn < min_lsn. In my opinion, both past and present are correct responses, but past is slightly better as the lsn returned by present with #7488 is one too "new". In practice, this shouldn't matter much, but shrug.

We agreed in slack that this is the better approach: https://neondb.slack.com/archives/C03F5SM1N02/p1713871064147029

@arpad-m arpad-m requested a review from koivunej April 26, 2024 13:38
@arpad-m arpad-m requested a review from a team as a code owner April 26, 2024 13:38
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Additionally I would like if we could move/add some of the documentation about this API and it's intention to endpoint to the openapi.yml. At least that's where I started when looking understanding how should this api work. Could be I missed some inter-doc link, if this is there already.

Copy link

2796 tests run: 2675 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_partial_evict_tenant[relative_spare]: release

Code coverage* (full report)

  • functions: 28.3% (6546 of 23138 functions)
  • lines: 47.0% (46234 of 98432 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
bc995db at 2024-04-26T14:18:11.151Z :recycle:

@arpad-m arpad-m merged commit 3942792 into main Apr 26, 2024
53 checks passed
@arpad-m arpad-m deleted the arpad/return_past branch April 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants