Return Past instead of Present or Future when commit_lsn < min_lsn #7520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an approach different from the one #7488 chose: We now return
past
instead ofpresent
(orfuture
) when encountering the edge case where commit_lsn < min_lsn. In my opinion, bothpast
andpresent
are correct responses, but past is slightly better as the lsn returned bypresent
with #7488 is one too "new". In practice, this shouldn't matter much, but shrug.We agreed in slack that this is the better approach: https://neondb.slack.com/archives/C03F5SM1N02/p1713871064147029