Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pageserver): add aux-file-v2 flag on tenant level #7505

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Apr 24, 2024

Problem

Changing metadata format is not easy. This pull request adds a tenant-level flag on whether to enable aux file v2. As long as we don't roll this out to the user and guarantee our staging projects can persist tenant config correctly, we can test the aux file v2 change with setting this flag. Previous discussion at #7424.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from arpad-m April 24, 2024 19:20
@skyzh skyzh requested a review from a team as a code owner April 24, 2024 19:20
Copy link

github-actions bot commented Apr 24, 2024

2766 tests run: 2645 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_gc_of_remote_layers: debug

Code coverage* (full report)

  • functions: 28.1% (6481 of 23049 functions)
  • lines: 47.0% (46064 of 98030 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d2ab310 at 2024-04-24T20:28:00.836Z :recycle:

@skyzh skyzh force-pushed the skyzh/aux-file-v2-tenant-flag branch from e85201a to 88dc0fb Compare April 24, 2024 19:29
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/aux-file-v2-tenant-flag branch from 88dc0fb to d2ab310 Compare April 24, 2024 19:46
@skyzh skyzh requested a review from jcsp April 25, 2024 14:44
@skyzh skyzh merged commit dbe0aa6 into main Apr 26, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/aux-file-v2-tenant-flag branch April 26, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants