-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics): correct maxrss metrics on macos #7487
Conversation
Signed-off-by: Alex Chi Z <chi@neon.tech>
2766 tests run: 2645 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
f093831 at 2024-04-24T15:17:14.747Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, ru_maxrss
on Linux also is in unit kilobytes
https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/getrusage.2.html
https://man7.org/linux/man-pages/man2/getrusage.2.html
oh, i mean it's bytes in macOS, and therefore we need to / 1024 on macOS to convert it to kilobytes. |
There seems to be a difference between ios (which you linked) and macosx (for which man pages are not online?): https://stackoverflow.com/a/59915669 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have the macosx man pages online, but there are other sources.
Indeed, confirmed on my mac. Would be nice to include that remark in a comment / commit message |
Signed-off-by: Alex Chi Z <chi@neon.tech>
added in f093831 |
Problem
macOS max_rss is in bytes, while Linux is in kilobytes. https://stackoverflow.com/a/59915669
Summary of changes
Checklist before requesting a review
Checklist before merging