Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage controller: grant 'admin' access to all APIs #7307

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Apr 4, 2024

Problem

Currently, using storcon-cli requires user to select a token with either pageserverapi or admin scope depending on which endpoint they're using.

Summary of changes

  • In check_permissions, permit access with the admin scope even if the required scope is missing. The effect is that an endpoint that required pageserverapi now accepts either pageserverapi or admin, and for the CLI one can simply use an admin scope token for everything.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller labels Apr 4, 2024
@jcsp jcsp requested a review from a team as a code owner April 4, 2024 08:54
@jcsp jcsp requested a review from arpad-m April 4, 2024 08:54
Copy link

github-actions bot commented Apr 4, 2024

2748 tests run: 2624 passed, 0 failed, 124 skipped (full report)


Code coverage* (full report)

  • functions: 27.9% (6381 of 22848 functions)
  • lines: 46.8% (44981 of 96053 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2434a6a at 2024-04-04T11:38:04.660Z :recycle:

@jcsp jcsp enabled auto-merge (squash) April 4, 2024 10:56
@jcsp jcsp merged commit 375e158 into main Apr 4, 2024
47 of 48 checks passed
@jcsp jcsp deleted the jcsp/storcon-admin-api branch April 4, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants