Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neonvm: add LFC approximate working set size to metrics #7252

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 26, 2024

Problem

ref neondatabase/autoscaling#878
ref neondatabase/autoscaling#872

Summary of changes

Add approximate_working_set_size to sql exporter so that autoscaling can use it in the future.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh marked this pull request as ready for review March 26, 2024 16:16
@skyzh skyzh requested a review from Bodobolero March 26, 2024 16:16
@skyzh
Copy link
Member Author

skyzh commented Mar 26, 2024

do not merge until #7231 gets merged

Copy link
Contributor

@Bodobolero Bodobolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have clarified in slack that we need to make sure that neon extension in compute VM is upgraded to latest version BEFORE this PR is merged and deployed in prod.
If they are deployed together, we will have some ephemeral errors in compute log at the first compute start after new image is in prod, but after that no more, which is fine.

vm-image-spec.yaml Outdated Show resolved Hide resolved
Co-authored-by: Peter Bendel <peterbendel@neon.tech>
@vadim2404 vadim2404 requested a review from zaynetro March 26, 2024 17:07
Copy link

2730 tests run: 2592 passed, 0 failed, 138 skipped (full report)


Code coverage* (full report)

  • functions: 28.2% (6298 of 22348 functions)
  • lines: 47.0% (44250 of 94192 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
06e37f2 at 2024-03-26T17:12:01.659Z :recycle:

@skyzh skyzh merged commit 7ddc7b4 into main Mar 29, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/lfc-working-set-size branch March 29, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants