Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy: do not store empty key #6415

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Proxy: do not store empty key #6415

merged 1 commit into from
Jan 20, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Jan 20, 2024

Problem

Currently we store in cache even if the project is undefined. That makes invalidation impossible.

Summary of changes

Do not store if project id is empty.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner January 20, 2024 14:15
@khanova khanova requested review from conradludgate and removed request for a team January 20, 2024 14:15
@khanova khanova enabled auto-merge (squash) January 20, 2024 14:39
Copy link

github-actions bot commented Jan 20, 2024

2262 tests run: 2179 passed, 0 failed, 83 skipped (full report)


Flaky tests (4)

Postgres 15

  • test_statvfs_pressure_usage: debug

Postgres 14

  • test_lfc_resize: debug
  • test_pg_regress: debug
  • test_empty_tenant_size: debug

Code coverage (full report)

  • functions: 54.5% (10601 of 19448 functions)
  • lines: 81.6% (60683 of 74406 lines)

The comment gets automatically updated with the latest test results
10bf61c at 2024-01-20T16:25:29.922Z :recycle:

@khanova khanova merged commit 9ace36d into main Jan 20, 2024
45 checks passed
@khanova khanova deleted the proxy-do-not-save-empty-key branch January 20, 2024 16:14
abhigets pushed a commit that referenced this pull request Jan 24, 2024
## Problem

Currently we store in cache even if the project is undefined. That makes
invalidation impossible.

## Summary of changes

Do not store if project id is empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants