Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better s3 error and backtrace for storage-scrubber (and storage client) #8361

Open
skyzh opened this issue Jul 11, 2024 · 2 comments
Open

better s3 error and backtrace for storage-scrubber (and storage client) #8361

skyzh opened this issue Jul 11, 2024 · 2 comments
Assignees
Labels
c/storage/pageserver Component: storage: pageserver t/bug Issue Type: Bug triaged bugs that were already triaged

Comments

@skyzh
Copy link
Member

skyzh commented Jul 11, 2024

as part of the fix #8299, I added two things:

  • Wrap S3 error with DisplayErrorContext to show the detailed error instead of simply status code.
  • For retries, throw the original error instead of the wrapped anyhow error.

This should be applied to other places in the pageserver codebase so that we have a consistent error reporting message.

@skyzh skyzh added t/bug Issue Type: Bug c/storage/pageserver Component: storage: pageserver labels Jul 11, 2024
@skyzh skyzh self-assigned this Jul 11, 2024
@arpad-m
Copy link
Member

arpad-m commented Jul 16, 2024

DisplayErrorContext is an S3 specific thing, does it work with Azure as well?

@skyzh
Copy link
Member Author

skyzh commented Jul 16, 2024

It's an S3 SDK thing

@jcsp jcsp added the triaged bugs that were already triaged label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/pageserver Component: storage: pageserver t/bug Issue Type: Bug triaged bugs that were already triaged
Projects
None yet
Development

No branches or pull requests

3 participants