Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_pageserver_recovery is flaky #7159

Closed
jcsp opened this issue Mar 18, 2024 · 0 comments · Fixed by #7207
Closed

test_pageserver_recovery is flaky #7159

jcsp opened this issue Mar 18, 2024 · 0 comments · Fixed by #7207
Assignees
@VladLazar
Labels
a/tech_debt Area: related to tech debt a/test Area: related to testing

Comments

@jcsp
Copy link
Collaborator

jcsp commented Mar 18, 2024

Could be related to storage controller heartbeats, as this is a test that leaves a node offline for some time.
@jcsp jcsp added a/test Area: related to testing a/tech_debt Area: related to tech debt labels Mar 18, 2024
@VladLazar VladLazar mentioned this issue Mar 25, 2024
Merged
5 tasks
VladLazar added a commit that referenced this issue Mar 25, 2024
@VladLazar
test: fix test_pageserver_recovery flakyness (#7207)
3a4ebfb 
## Problem
We recently introduced log file validation for the storage controller.
The heartbeater will WARN when it fails
for a node, hence the test fails.

Closes #7159

## Summary of changes
* Warn only once for each set of heartbeat retries
* Allow list heartbeat warns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VladLazar VladLazar

Labels
a/tech_debt Area: related to tech debt a/test Area: related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test_pageserver_recovery flakyness neondatabase/neon
2 participants
@jcsp @VladLazar