Skip to content

Commit

Permalink
Fix query error in vm-image-spec.yaml (#8028)
Browse files Browse the repository at this point in the history
This query causes metrics exporter to complain about missing data
because it can't find the correct column.

Issue was introduced with #7761
  • Loading branch information
MMeent authored Jun 12, 2024
1 parent 836d1f4 commit ad0ab3b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion vm-image-spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,9 @@ files:
- slot_name
values: [restart_lsn]
query: |
select slot_name, (restart_lsn - '0/0')::FLOAT8 from pg_replication_slots where slot_type = 'logical';
select slot_name, (restart_lsn - '0/0')::FLOAT8 as restart_lsn
from pg_replication_slots
where slot_type = 'logical';
- metric_name: retained_wal
type: gauge
Expand Down

1 comment on commit ad0ab3b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3298 tests run: 3146 passed, 1 failed, 151 skipped (full report)


Failures on Postgres 14

  • test_pageserver_max_throughput_getpage_at_latest_lsn[github-actions-selfhosted-10-6-30]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_pageserver_max_throughput_getpage_at_latest_lsn[release-pg14-github-actions-selfhosted-10-6-30]"

Code coverage* (full report)

  • functions: 31.6% (6624 of 20990 functions)
  • lines: 48.6% (51510 of 106058 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ad0ab3b at 2024-06-12T19:44:45.884Z :recycle:

Please sign in to comment.