-
Notifications
You must be signed in to change notification settings - Fork 434
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
proxy: lazily parse startup pg params (#7905)
## Problem proxy params being a `HashMap<String,String>` when it contains just ``` application_name: psql database: neondb user: neondb_owner ``` is quite wasteful allocation wise. ## Summary of changes Keep the params in the wire protocol form, eg: ``` application_name\0psql\0database\0neondb\0user\0neondb_owner\0 ``` Using a linear search for the map is fast enough at small sizes, which is the normal case.
- Loading branch information
1 parent
fddd11d
commit 9a081c2
Showing
4 changed files
with
46 additions
and
36 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a081c2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3262 tests run: 3117 passed, 0 failed, 145 skipped (full report)
Flaky tests (6)
Postgres 15
test_timeline_deletion_with_files_stuck_in_upload_queue
: debugtest_vm_bit_clear_on_heap_lock
: release, debugPostgres 14
test_pageserver_restarts_under_worload
: releasetest_timeline_deletion_with_files_stuck_in_upload_queue
: debugtest_replication_start
: releaseCode coverage* (full report)
functions
:31.4% (6485 of 20666 functions)
lines
:48.4% (50201 of 103758 lines)
* collected from Rust tests only
9a081c2 at 2024-05-30T12:54:49.205Z :recycle: