Skip to content

Commit

Permalink
Fix test_replica_query_race flakiness (#8038)
Browse files Browse the repository at this point in the history
This failed once with `relation "test" does not exist` when trying to
run the query on the standby. It's possible that the standby is started
before the CREATE TABLE is processed in the pageserver, and the standby
opens up for queries before it has received the CREATE TABLE transaction
from the primary. To fix, wait for the standby to catch up to the
primary before starting to run the queries.


https://neon-github-public-dev.s3.amazonaws.com/reports/pr-8025/9483658488/index.html
  • Loading branch information
hlinnaka authored Jun 14, 2024
1 parent 425eed2 commit 7891965
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test_runner/regress/test_hot_standby.py
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ def test_replica_query_race(neon_simple_env: NeonEnv):
p_cur.execute("CREATE TABLE test AS SELECT 0 AS counter")

standby_ep = env.endpoints.new_replica_start(origin=primary_ep, endpoint_id="standby")
time.sleep(1)
wait_replica_caughtup(primary_ep, standby_ep)

# In primary, run a lot of UPDATEs on a single page
finished = False
Expand Down

1 comment on commit 7891965

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3304 tests run: 3152 passed, 1 failed, 151 skipped (full report)


Failures on Postgres 14

  • test_download_churn[github-actions-selfhosted-100-std-fs-30]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_download_churn[release-pg14-github-actions-selfhosted-100-std-fs-30]"
Flaky tests (1)

Postgres 15

  • test_storage_controller_smoke: release

Code coverage* (full report)

  • functions: 31.5% (6634 of 21060 functions)
  • lines: 48.6% (51625 of 106254 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7891965 at 2024-06-14T10:31:48.992Z :recycle:

Please sign in to comment.