Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pageserver: fix a warning on secondary mode downloads after evictions (…
…#7877) ## Problem In 4ce6e2d we added a warning when progress stats don't look right at the end of a secondary download pass. This `Correcting drift in progress stats` warning fired in staging on a pageserver that had been doing some disk usage eviction. The impact is low because in the same place we log the warning, we also fix up the progress values. ## Summary of changes - When we skip downloading a layer because it was recently evicted, update the progress stats to ensure they still reach a clean complete state at the end of a download pass. - Also add a log for evicting secondary location layers, for symmetry with attached locations, so that we can clearly see when eviction has happened for a particular tenant's layers when investigating issues. This is a point fix -- the code would also benefit from being refactored so that there is some "download result" type with a Skip variant, to ensure that we are updating the progress stats uniformly for those cases.
- Loading branch information
352b08d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3232 tests run: 3086 passed, 0 failed, 146 skipped (full report)
Flaky tests (1)
Postgres 16
test_vm_bit_clear_on_heap_lock
: debugCode coverage* (full report)
functions
:31.4% (6448 of 20544 functions)
lines
:48.3% (49954 of 103359 lines)
* collected from Rust tests only
352b08d at 2024-05-28T16:26:23.063Z :recycle: