-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitter refactoring #202
Splitter refactoring #202
Commits on Apr 23, 2019
-
Move some inputs.py classes to builder/inputs.py
From nengo_loihi.inputs. These classes are only used as part of the build process and should not be made alongside Block and LoihiInput instances.
Configuration menu - View commit details
-
Copy full SHA for 00d89de - Browse repository at this point
Copy the full SHA 00d89deView commit details
Commits on Apr 24, 2019
-
Disallow passing network=None to simulator
Also corrects an incorrect default in the simulator docstring.
Configuration menu - View commit details
-
Copy full SHA for cbbe988 - Browse repository at this point
Copy the full SHA cbbe988View commit details -
Raise tolerance for test_pes_comm_channel
The test was fragile with the old tolerances, failing for many seeds.
Configuration menu - View commit details
-
Copy full SHA for 15fdd46 - Browse repository at this point
Copy the full SHA 15fdd46View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5002bd - Browse repository at this point
Copy the full SHA f5002bdView commit details -
Most of the work done by the splitter is now done in the builder. This should give more clarity and control over the mapping between pre-build and post-build objects. The `Split` class takes on the organizational tasks of the old `Splitter`, giving directives to the builder about what should be on- or off-chip. Several tests were added or modified to ensure that these changes did not affect built models in adverse ways. Some tests were added to ensure that the refactoring made improvements; for example, the refactored splitter no longer mutates networks, which closes #211. Simulations should now be identical whether precompute is True or False, so the tolerance in test_precompute is now set to zero. The passthrough removal process was also modified to act in the same way as `Split`, and is now named `PassthroughSplit` accordingly. Co-authored-by: Trevor Bekolay <tbekolay@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c25818a - Browse repository at this point
Copy the full SHA c25818aView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa46281 - Browse repository at this point
Copy the full SHA aa46281View commit details -
Configuration menu - View commit details
-
Copy full SHA for e116b91 - Browse repository at this point
Copy the full SHA e116b91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11ad56d - Browse repository at this point
Copy the full SHA 11ad56dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 273f39d - Browse repository at this point
Copy the full SHA 273f39dView commit details -
Test conv weights without lowpass
Covers some previously uncovered lines in `conv.py`.
Configuration menu - View commit details
-
Copy full SHA for d44019c - Browse repository at this point
Copy the full SHA d44019cView commit details -
Change raised exceptions to NengoExceptions
There were a few places where we were raising errors that were not subclasses of NengoException. They are now appropriate NengoExceptions.
Configuration menu - View commit details
-
Copy full SHA for 1c45761 - Browse repository at this point
Copy the full SHA 1c45761View commit details -
A keyword argument changed in a recent abr_control commit.
Configuration menu - View commit details
-
Copy full SHA for 57fdf40 - Browse repository at this point
Copy the full SHA 57fdf40View commit details
Commits on Apr 26, 2019
-
Revert "Parallelize hardware tests"
This partially reverts commit 70ecb8a. The patch to graph.Graph seems to be incomplete, as one process could be writing to the file to be copied while another process is attempting to read it. The includes are also not copied, so likely we need a more robust solution for writing snip files to temporary directories. The command was only changed to request one worker instead of two.
Configuration menu - View commit details
-
Copy full SHA for e9cd851 - Browse repository at this point
Copy the full SHA e9cd851View commit details