Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitter refactoring #202

Merged
merged 13 commits into from
Apr 26, 2019
Merged

Splitter refactoring #202

merged 13 commits into from
Apr 26, 2019

Commits on Apr 23, 2019

  1. Move some inputs.py classes to builder/inputs.py

    From nengo_loihi.inputs. These classes are only used as part of
    the build process and should not be made alongside Block and
    LoihiInput instances.
    arvoelke committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    00d89de View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. Disallow passing network=None to simulator

    Also corrects an incorrect default in the simulator docstring.
    arvoelke authored and tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    cbbe988 View commit details
    Browse the repository at this point in the history
  2. Raise tolerance for test_pes_comm_channel

    The test was fragile with the old tolerances, failing for many seeds.
    arvoelke authored and tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    15fdd46 View commit details
    Browse the repository at this point in the history
  3. Move build_conv2d_connection to builder

    arvoelke authored and tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    f5002bd View commit details
    Browse the repository at this point in the history
  4. Combine splitter into builder

    Most of the work done by the splitter is now done in the builder.
    This should give more clarity and control over the mapping between
    pre-build and post-build objects. The `Split` class takes on the
    organizational tasks of the old `Splitter`, giving directives to
    the builder about what should be on- or off-chip.
    
    Several tests were added or modified to ensure that these changes
    did not affect built models in adverse ways. Some tests were added
    to ensure that the refactoring made improvements; for example, the
    refactored splitter no longer mutates networks, which closes #211.
    Simulations should now be identical whether precompute is True
    or False, so the tolerance in test_precompute is now set to zero.
    
    The passthrough removal process was also modified to act in the
    same way as `Split`, and is now named `PassthroughSplit` accordingly.
    
    Co-authored-by: Trevor Bekolay <tbekolay@gmail.com>
    arvoelke and tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    c25818a View commit details
    Browse the repository at this point in the history
  5. Fix flake8 checking

    Also fix an issue caught by flake8
    tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    aa46281 View commit details
    Browse the repository at this point in the history
  6. Handle sliced probes

    Closes #205 and #206.
    arvoelke authored and tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    e116b91 View commit details
    Browse the repository at this point in the history
  7. Pass no decoder cache to sub-models

    The decoder cache does not work for host models due to having
    no context manager, which is normally constructed by the
    top-level network builder.
    
    This commit fixes #207 as it does not globally disable the
    decoder cache. We also add some asserts to existing tests
    for ensure that #207 is fixed.
    arvoelke authored and tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    11ad56d View commit details
    Browse the repository at this point in the history
  8. Raise BuildError if learning objects are on_chip

    Fixes #208 and #209.
    arvoelke authored and tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    273f39d View commit details
    Browse the repository at this point in the history
  9. Test conv weights without lowpass

    Covers some previously uncovered lines in `conv.py`.
    arvoelke authored and tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    d44019c View commit details
    Browse the repository at this point in the history
  10. Change raised exceptions to NengoExceptions

    There were a few places where we were raising errors that were
    not subclasses of NengoException. They are now appropriate
    NengoExceptions.
    tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    1c45761 View commit details
    Browse the repository at this point in the history
  11. Fix adaptive control notebook

    A keyword argument changed in a recent abr_control commit.
    tbekolay committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    57fdf40 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. Revert "Parallelize hardware tests"

    This partially reverts commit
    70ecb8a.
    
    The patch to graph.Graph seems to be incomplete, as one process
    could be writing to the file to be copied while another process
    is attempting to read it. The includes are also not copied, so
    likely we need a more robust solution for writing snip files to
    temporary directories.
    
    The command was only changed to request one worker instead of two.
    tbekolay committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    e9cd851 View commit details
    Browse the repository at this point in the history