-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
squash! Combine splitter into builder
Rename PassthroughDirective -> PassthroughSplit Like SplitterDirective, PassthroughDirective is a bit clunky, and definitely doesn't make sense if there is no SplitterDirective. This name attempts to make the relationship between Split and PassthroughSplit more clear, which is that a PassthroughSplit is a specific type of Split (though they are not a class/subclass relationship, so it's only a specific type in a conceptual sense).
- Loading branch information
Showing
7 changed files
with
136 additions
and
143 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
I've had to remind myself of this a couple times now (for all of the
base_obj
calls andpre_obj
references) of the following fact, so it might be worth adding a comment to the effect of:We assume neither pre nor post can be a probe (since they are end-points of a connection), and so we do not need to resolve any underlying .target objects here
.