-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for nengo_spa. #891
Conversation
Just before things go too far in this direction, I'm definitely going to make it a requirement that we will have to support |
(and, I think you're right that the eventual path to that involves the refactoring and then the plugin system, and then this ends up in |
Yes, I'm on board with that. I just wanted to have an initial possibility to get the plots for If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should definitely get merged, and it looks good to me. It'll get reworked when we connect nengo_spa and nengo_gui using the plugin system, but for now it's really useful to be able to use both nengo.spa
and nengo_spa
in the GUI. (Especially as we'd like to use nengo_spa
in this year's summer school.
This adds basic support for
nengo_spa
, but breaks support fornengo.spa
(note the dot instead of underscore). There might still be things that do not work properly and before a merge the complete SPA related code needs to be gone through and checked.I think there are slightly to many differences to conveniently support both SPA versions. With some refactoring this might be more realistic, but that also requires more effort and it migth be better to wait for the refactored frontend #806.
Ultimately, I expect these classes to move to
nengo_spa
, but this requires the plugin structure to be in place which I probably won't tackle before the frontend refactoring is done either.