Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for nengo_spa. #891

Merged
merged 3 commits into from
May 24, 2018
Merged

Basic support for nengo_spa. #891

merged 3 commits into from
May 24, 2018

Conversation

jgosmann
Copy link
Collaborator

This adds basic support for nengo_spa, but breaks support for nengo.spa (note the dot instead of underscore). There might still be things that do not work properly and before a merge the complete SPA related code needs to be gone through and checked.

I think there are slightly to many differences to conveniently support both SPA versions. With some refactoring this might be more realistic, but that also requires more effort and it migth be better to wait for the refactored frontend #806.

Ultimately, I expect these classes to move to nengo_spa, but this requires the plugin structure to be in place which I probably won't tackle before the frontend refactoring is done either.

@tcstewar
Copy link
Collaborator

Just before things go too far in this direction, I'm definitely going to make it a requirement that we will have to support nengo_spa and nengo.spa at the same time. It does make sense to have a branch like this for working with nengo_spa, but we'll have to support both before it gets merged.

@tcstewar
Copy link
Collaborator

(and, I think you're right that the eventual path to that involves the refactoring and then the plugin system, and then this ends up in nengo_spa rather than in nengo_gui)

@jgosmann
Copy link
Collaborator Author

Just before things go too far in this direction, I'm definitely going to make it a requirement that we will have to support nengo_spa and nengo.spa at the same time.

Yes, I'm on board with that. I just wanted to have an initial possibility to get the plots for nengo_spa. This is not intended to be merged in the current form (but the PR might make it easier to find if anyone needs it).

If nengo_spa provides the plots via a plugin system, the problem of supporting both should be solved because nengo_gui can still provide the code for legacy SPA without any changes and nengo_spa would provide the code that it needs itself.

Copy link
Collaborator

@tcstewar tcstewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely get merged, and it looks good to me. It'll get reworked when we connect nengo_spa and nengo_gui using the plugin system, but for now it's really useful to be able to use both nengo.spa and nengo_spa in the GUI. (Especially as we'd like to use nengo_spa in this year's summer school.

@tcstewar tcstewar merged commit 3482211 into master May 24, 2018
@tcstewar tcstewar deleted the nengo_spa branch May 24, 2018 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants