Fix resource unavailable bug

[tcstewar]

At the moment, we don't handle a full socket gracefully. This mostly comes up if you have a large complex htmlview, which ends up breaking horribly once everything fills up.

I still need to put together a nice test, but here's a fix (this was reported in #813 )

[mention-bot]

@tcstewar, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jgosmann, @studywolf and @hunse to be potential reviewers

[jgosmann]

I think the code could potentially be simplified by doing always a select call first and not catching any exceptions.

As for a good test ... we could open up a websocket connection, fill it up and check that no exception is raised. It's a little bit complicated to implement because to threads have to be coordinated ... not sure if it's worth the hassle.

[tcstewar]

I think the code could potentially be simplified by doing always a select call first and not catching any exceptions.

Oooo... also a very good idea. Much much cleaner, and seems to work well. :)

[tcstewar]

Since @jgosmann suggested the entire contents of this one-line fix, I'm going to act as the reviewer for it, even though I made the PR. Thank you @jgosmann , it looks good to me (and I just checked that it still fixes things when the HtmlNode has lots of content)