Slider with axis to show range #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool... I like the basic look. The main weirdness is that it seems like the sliders should be squished a bit to the right so that they don't overlap with the line... but then that means there's a bunch of empty space Also, the numbers on the axis seem to be 0 and 1 rather than -1 and 1, and the "Set range..." doesn't work, but I assumer that's being worked on. |
|
This PR is quite old and marked as "needs changes". Is this still something that makes sense to review? Does it make sense to do so without the required changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a demo of slider with an axis to show the range (for visual purposes only) , If it looks ok I will clean up the code (which is a mess right now) for merge.
fix #123, #464