remove dns sleep #2550
Merged
remove dns sleep #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciusdc
reviewed
Jun 29, 2024
| input( | ||
| f"After attempting to poll the DNS, the record for domain={domain_name} appears not to exist, " | ||
| f"has recently been updated, or has yet to fully propagate. This non-deterministic behavior is likely due to " | ||
| f"DNS caching and will likely resolve itself in a few minutes.\n\n\tTo poll the DNS again in {sleeptime} seconds " | ||
| f"[Press Enter].\n\n...otherwise kill the process and run the deployment again later..." | ||
| f"DNS caching and will likely resolve itself in a few minutes.\n\n\tTo poll the DNS again [Press Enter].\n\n" |
There was a problem hiding this comment.
@Adam-D-Lewis Can we add extra information to let the user know this will only run up to five times? Something like [4/5]
viniciusdc
approved these changes
Jun 29, 2024
There was a problem hiding this comment.
Makes sense, thanks @Adam-D-Lewis -- I left an optional suggestion above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
There is no need for a sleep on trying DNS lookup unless you've disabled the prompt since it waits til you press Enter anyways. This removes the sleep the case you haven't disabled prompts.
What does this implement/fix?
Put a
xin the boxes that applyTesting
Any other comments?