Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve commit title #31

Open
JohnTitor opened this issue Jan 30, 2019 · 1 comment
Open

Improve commit title #31

JohnTitor opened this issue Jan 30, 2019 · 1 comment
Labels
Priority: Medium

Comments

@JohnTitor
Copy link
Contributor

JohnTitor commented Jan 30, 2019 •
edited
Loading

Merging the pull request, frau leaves commit message as follow:
screenshot 8689466

This isn't bad, however, you cannot know who approved it just seeing this.
I think this commit title may be better: Auto merge of #[PR's number] - r=[approver]
@JohnTitor
Copy link
Contributor Author

If including reviewers, we should fix #16 first. And at now, commit title can be included more than one person. It may be lengthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JohnTitor