Nats web socket opts improvements #623
Conversation
* Separate model NatsWebSocketOpts * Сalled NatsTlsOpts.AuthenticateAsClientAsync parameters before passing it to the ConfigureWebSocketOpts * RequestHeaders overwrite the header specified in ConfigureWebSocketOpts
* Added test
|
@caleblloyd can you take look? Did I interpret all the ideas you had in mind correctly? |
|
I will try to take a look tomorrow! |
Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com>
|
Here are some un-tested recommendations based on your PR: 4da55d4 Feel free to cherry-pick that commit into this branch if you think it looks good. The 2 main things left to do:
|
Thanks, I'll run some tests |
* Fence added, an occurs exceptions when add headers to blazor
|
@caleblloyd I checked when adding headers to Blazor, an error appears.
|
|
It’s more the TLS options I was worried about but maybe it is ok to throw there too? I don’t know how common it is for someone to configure an Isomorphic client for Blazor and .NET projects. |
This reverts commit e6b9d1c.
Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com>
Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com>
|
I think we don't need detect or ignore Blazor right now, since Headers would need to be explicitly added. I changed the TLS check to look for TLS Certs being explicitly added. Also added some tests for WebSocketSecure |
Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com>
There was a problem hiding this comment.
Approved, @mtmk can you take a quick look and merge if you're happy?
|
@caleblloyd Thanks for help :) |
* NatsWebSocketOpts improvements (nats-io#610) * Separate model NatsWebSocketOpts * Сalled NatsTlsOpts.AuthenticateAsClientAsync parameters before passing it to the ConfigureWebSocketOpts * RequestHeaders overwrite the header specified in ConfigureWebSocketOpts * NatsWebSocketOpts improvements (nats-io#610) * Added test * Build fixes * Build fixes * Build fixes * dotnet format * nats-io#623 reccomendations Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com> * NatsWebSocketOpts improvements (nats-io#610) * Fence added, an occurs exceptions when add headers to blazor * Revert "NatsWebSocketOpts improvements (nats-io#610)" This reverts commit e6b9d1c. * WebSocketSecure tests Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com> * fix format Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com> * simplify WebSocketOptionsTest Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com> --------- Signed-off-by: Caleb Lloyd <caleblloyd@gmail.com> Co-authored-by: Ziya Suzen <ziya@suzen.net> Co-authored-by: Caleb Lloyd <caleblloyd@gmail.com>
* Fixed consume pending message calculation * ServiceProvider callback for NATS DI configuration (nats-io#619) * Nats web socket opts improvements (nats-io#623) * Fix various disposable issues (nats-io#625) * Make NuidWriter public (nats-io#618) * NatsOpts.ConfigureWebSocketOpts callback handler (nats-io#605)
Resolves #610