Adding SNI extension if available #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thierryba
force-pushed
the
adding_sni_extension
branch
from
9f9b70d
to
8ee4618
Compare
kozlovic
requested changes
Aug 9, 2024
|
@kozlovic if we'd have a simple tcp server that could listen to connection we could probably configure the client to connect to it with tls_handshake_first... and we could check that the client hello does contain the SNI extension (which is in clear). Would that make sense? |
thierryba
force-pushed
the
adding_sni_extension
branch
from
d977e65
to
544ba91
Compare
kozlovic
requested changes
Aug 12, 2024
kozlovic
approved these changes
Aug 12, 2024
|
Thanks, @thierryba! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the SNI extension and completes the ability to use nits-server per instance in the cloud with automatic load balancing.
This fixes #786