[CI only] Use RelWithDebInfo in Travis to get the callstacks #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
==========================================
+ Coverage 68.71% 68.88% +0.17%
==========================================
Files 39 49 +10
Lines 15207 15219 +12
Branches 3143 3133 -10
==========================================
+ Hits 10449 10484 +35
+ Misses 1700 1687 -13
+ Partials 3058 3048 -10 ☔ View full report in Codecov by Sentry. |
|
As soon as I added |
|
@levb What I would do to test is modify a test to cause a data race or whatever the matrix is supposed to catch and see if the output is what you expect. Even a simple memory leak should produce an output, so I would take the first test to be executed and do a malloc without a free. You could do that in a separate commit that - once you verify that it works as expected - you would drop and "push force" without this commit. Makes sense? |
|
Right, I know that the call stack is displayed (on GHA, at least) - that's why I added these. But it appears that the races/whatever the warnings were just stopped happening with the symbol tables included. So I'd like to see if it really is the case. It is not a pressing issue, but I'd like to understand why is Travis still finding issues that GHA is not catching. |
Oh sorry, I thought you meant that you wanted to know if it would be displayed correctly :-)
My guess is timing. I believe that the Travis VMs (especially outside of the NATS server) are pretty basic/slow. |
|
@levb I got one on GA, not sure if this is the one you were trying to catch? |
|
@kozlovic thanks! This and one more that just happened point to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis sanitize builds seem to still produce unique failures that are not appearing in GHA jobs. However, some were compiled with
Releasemaking call stack interpretation difficult (like, https://app.travis-ci.com/github/nats-io/nats.c/jobs/624866438). UseRelWithDebInfoto get the call stacks with symbols (hope it works in that environment, will see)