Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed microservice cleanup and tests #660

Merged
merged 35 commits into from
Jun 10, 2023
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
c3677d2
try-1
levb May 23, 2023
b3ee831
wip
levb May 29, 2023
7d732fb
wip
levb May 29, 2023
de0f8a8
wip2
levb May 29, 2023
e531f28
wip3
levb May 29, 2023
0e85175
wip4
levb May 29, 2023
e4b80fd
wip5
levb May 30, 2023
71bb342
reworked wip
levb May 31, 2023
c38ed27
reworked wip2
levb Jun 1, 2023
3d0d3ab
reworked wip3
levb Jun 1, 2023
cb68bad
reworked wip4
levb Jun 1, 2023
a4d89bc
reworked wip5
levb Jun 1, 2023
8f87ea2
reworked wip5
levb Jun 1, 2023
3ca86b6
reworked wip6
levb Jun 2, 2023
5dab55d
Merge branch 'main' into lev-tmp2
levb Jun 2, 2023
52c4881
reworked wip7
levb Jun 3, 2023
2019f51
reworked wip8
levb Jun 3, 2023
f76a3c5
reworked wip9
levb Jun 3, 2023
863af3e
Merge branch 'lev-microservice-proto' into lev-tmp2
levb Jun 3, 2023
104a46c
reworked wip10
levb Jun 3, 2023
b80dc96
reworked wip11
levb Jun 3, 2023
5ae5e6f
reworked wip12
levb Jun 3, 2023
e2d41f0
reworked wip13
levb Jun 3, 2023
f1f1191
reworked wip14
levb Jun 4, 2023
8d66c11
reworked wip15
levb Jun 4, 2023
9da1b56
wip nits
levb Jun 4, 2023
10fe2c5
wip more nits
levb Jun 4, 2023
b01f694
Merge branch 'lev-microservice-proto' of github.com:nats-io/nats.c in…
levb Jun 5, 2023
f255707
Moving global variables inside natsLib for proper cleanup on close
kozlovic Jun 5, 2023
4e0709d
PR feedback sans global elimination
levb Jun 6, 2023
2474610
Merge branch 'lev-tmp2' of github.com:nats-io/nats.c into lev-tmp2
levb Jun 6, 2023
394e4b2
Restored num_services=5 in tests
levb Jun 6, 2023
fd95b7b
PR feedback: microError.message
levb Jun 7, 2023
e92657b
PR feedback: nats_vsnprintf
levb Jun 7, 2023
338951d
PR feedback: nats_vsnprintf, #2
levb Jun 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/conn.c
Original file line number Diff line number Diff line change
Expand Up @@ -2015,7 +2015,7 @@ _connect(natsConnection *nc)
bool retry = false;
bool retryOnFailedConnect = false;
bool hasConnectedCb = false;

natsOptions_lock(nc->opts);
hasConnectedCb = (nc->opts->connectedCb != NULL);
retryOnFailedConnect = nc->opts->retryOnFailedConnect;
Expand Down
2 changes: 1 addition & 1 deletion src/conn.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2015-2023 The NATS Authors
// Copyright 2015-2021 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
Expand Down
Loading