added natsConn_(get|set)(Error|Closed)Callback
#647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
requested changes
Apr 6, 2023
kozlovic
reviewed
Apr 6, 2023
|
Oops, @kozlovic sorry I tagged you too early; I pushed to run the tests, still finishing this up. Thanks for jumping onto it! |
kozlovic
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
LGTM. Just a note, since recently, it is assumed that the async error callback will always be set (if not set by the user, we use a default handler that prints to stderr, see natsConn_defaultErrHandler). I see that your new setter does not allow NULL, so there is no risk at the moment that you would remove the error handler. If you do in the future, check invocations of natsAsyncCb_PostErrHandler that again assume that a callback is always set.
Merged
|
#640 has an improved implementation, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use in the microservices implementation, to wrap connection handlers on an active connection.
(still need to add a test for
setClosedCallback)