Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom model path #22

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

kvantricht
Copy link
Contributor

Simplest solution for my issue (raised in #21) right now is something like this. Let me know what you think.

presto/presto.py Outdated Show resolved Hide resolved
@gabrieltseng
Copy link
Collaborator

Aside from the single comment, this looks good to me. Thank you @kvantricht !

@gabrieltseng
Copy link
Collaborator

@kvantricht isort is failing. We run the following linting / formatting checks against the code:

isort . 
black .
flake8 .

@kvantricht
Copy link
Contributor Author

@kvantricht isort is failing. We run the following linting / formatting checks against the code:

isort . 
black .
flake8 .

okay new attempt ;-)

@kvantricht
Copy link
Contributor Author

Argh this is a struggle, seems that my own linter screwed up some other formatting ...

@gabrieltseng
Copy link
Collaborator

Argh this is a struggle, seems that my own linter screwed up some other formatting ...

I am happy to make these changes, since I have everything set up locally

@kvantricht
Copy link
Contributor Author

Argh this is a struggle, seems that my own linter screwed up some other formatting ...

I am happy to make these changes, since I have everything set up locally

If I run black ., then he's indeed going to revert that one formatting change but also remove some blank lines. So I'm not sure why it's behaving differently here. Please go ahead if it's an easy fix on your side.

@gabrieltseng gabrieltseng merged commit 324fcca into nasaharvest:main Oct 18, 2023
1 check failed
@kvantricht kvantricht deleted the custom_model_path branch October 18, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants