Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #155, Convert int32 return codes and variables to CFE_Status_t #156

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix #155, Convert int32 return codes and variables to CFE_Status_t #156

merged 1 commit into from
Nov 14, 2023

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully.
Local testing with full cFS suite passing all tests and showing not change to coverage.

Expected behavior changes
No change to behavior.
CFE_Status_t is more expressive and improves consistency with cFE/cFS.

Contributor Info
Avi Weiss @thnkslprpt

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 24, 2023
View reviewed changes
fsw/src/to_lab_app.c
@@ -458,10 +458,10 @@
/* TO_LAB_AddPacket() -- Add packets */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 TO_LAB_AddPacket(const TO_LAB_AddPacketCmd_t *data)
CFE_Status_t TO_LAB_AddPacket(const TO_LAB_AddPacketCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_app.c
@@ -376,7 +376,7 @@
/* TO_LAB_SendDataTypes() -- Output data types */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 TO_LAB_SendDataTypes(const TO_LAB_SendDataTypesCmd_t *data)
CFE_Status_t TO_LAB_SendDataTypes(const TO_LAB_SendDataTypesCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_app.c
@@ -235,7 +235,7 @@
/* TO_LAB_EnableOutput() -- TLM output enabled */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 TO_LAB_EnableOutput(const TO_LAB_EnableOutputCmd_t *data)
CFE_Status_t TO_LAB_EnableOutput(const TO_LAB_EnableOutputCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_app.c
@@ -128,14 +128,14 @@
/* TO_LAB_init() -- TO initialization */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 TO_LAB_init(void)
CFE_Status_t TO_LAB_init(void)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_app.c
@@ -128,14 +128,14 @@
/* TO_LAB_init() -- TO initialization */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 TO_LAB_init(void)
CFE_Status_t TO_LAB_init(void)

Check notice

Code scanning / CodeQL

Function too long

TO_LAB_init has too many lines (101, while 60 are allowed).
fsw/src/to_lab_app.c
@@ -505,10 +505,10 @@
/* TO_LAB_RemoveAll() -- Remove All Packets */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 TO_LAB_RemoveAll(const TO_LAB_RemoveAllCmd_t *data)
CFE_Status_t TO_LAB_RemoveAll(const TO_LAB_RemoveAllCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_app.c
@@ -483,10 +483,10 @@
/* TO_LAB_RemovePacket() -- Remove Packet */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 TO_LAB_RemovePacket(const TO_LAB_RemovePacketCmd_t *data)
CFE_Status_t TO_LAB_RemovePacket(const TO_LAB_RemovePacketCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
jphickey
jphickey approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to get these into the next round

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 1, 2023
@jphickey jphickey mentioned this pull request Nov 1, 2023
Merged
2 tasks
@dzbaker dzbaker added CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Nov 2, 2023
@dzbaker dzbaker mentioned this pull request Nov 13, 2023
Merged
2 tasks
@dzbaker dzbaker merged commit 348f304 into nasa:main Nov 14, 2023
@thnkslprpt thnkslprpt deleted the fix-155-convert-int-32-return-codes-to-CFE_Status_t branch November 14, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey jphickey approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates approval by CCB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_lab int32 return codes and variables should be converted to CFE_Status_t
3 participants
@thnkslprpt @jphickey @dzbaker