Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11, Implemented cFE Table Service #12

Closed
wants to merge 1 commit into from
Closed

Fix #11, Implemented cFE Table Service #12

wants to merge 1 commit into from

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Sep 9, 2019

Describe the contribution
Fix #11, Implemented cFE table service

Testing performed
Steps taken to test the contribution:

  1. Build

  2. Used GroundSystem to enable telemetry

  3. Used Cosmos to verify package received:
    a. CFE_ES - HK_TLM_PKT
    b. CFDP – CFDP_ENGINE_HK
    c. CFE_EVS – HK_TML_PKT
    d. CFE_SB – HK_TLM_PKT
    e. CFE_TBL = HK_TLM_PKT
    f. CFE_TIME – HK_TLM_PKT
    g. KIT_CI – HK_TLM_PKT
    h. KIT_TO – HK_TLM_PKT
    i. UNKOWN

  4. Systematically removed each individual MID from table and verify:
    a. Removed CFE_ES_SEND_HK_MID. Verify CFE_ES is not receiving
    b. Removed CFE_EVS_SEND_HK_MID. Verify CFE_EVS is not receiving
    c. Removed CFE_TIME_SEND_HK_MID. Verify CFE_TIME is not receiving
    d. Removed CFE_SB_SEND_HK_MID. Verify CFE_SB is not receiving
    e. Removed CFE_TBL_SEND_HK_MID. Verify CFE_TBL is not receiving
    f. Removed CI_LAB_SEND_HK_MID. Verify Kit-CI is not receiving
    g. Removed TO_LAB_SEND_HK_MID. Verify Kit-To is not receiving any package
    h. Removed SAMPLE_APP_SEND_HK_MID. Verify Unknown is not receiving any package

*Note - Sample_App correspond to Unknown in Cosmos

Expected behavior changes
No impact to behavior.

System(s) tested on:

  • Hardware
  • OS: Ubuntu 18.04.03
  • Cosmos 4.4.0 (part of OpenSatKit), GroundSystem 2.0.90a , cFE 6.6.0a, OSAL 1.4.2a

Additional context
None

Contributor Info
Anh Van, NASA Goddard

Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted

@avan989 avan989 changed the title Add table Fix #17, Implemented cFE Table Service Sep 9, 2019
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #11, not #17. Update title and commit

@avan989 avan989 changed the title Fix #17, Implemented cFE Table Service Fix #11, Implemented cFE Table Service Sep 24, 2019
@avan989
Copy link
Contributor Author

avan989 commented Sep 24, 2019

do you mean update title and comment? or do you mean update the title name and commit name?

@skliper
Copy link
Contributor

skliper commented Sep 24, 2019

It's helpful if you can amend the commit comment to match the preferred format to make the integration candidate and merge process simpler:

Fix #x, Short Description

Long description (if needed)

@avan989
Copy link
Contributor Author

avan989 commented Sep 24, 2019

Title and commit changed.

Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has conflicts, rebase on current master and resolve.

@avan989 avan989 closed this Sep 25, 2019
@avan989
Copy link
Contributor Author

avan989 commented Sep 25, 2019

messed up. Restart pull requst

@avan989 avan989 mentioned this pull request Sep 25, 2019
@skliper skliper added the invalid This doesn't seem right label Oct 15, 2019
@skliper skliper mentioned this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule App not using CFE Table
2 participants