Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Candidate 20191230 #14

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Integration Candidate 20191230 #14

merged 2 commits into from
Jan 9, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Dec 31, 2019

Describe the contribution
Fix #8

Testing performed

  1. Checked out all IC 20191230 branches
  2. Built and ran cFS unit tests and OSAL coverage (vxworks and shared)
    1. All passed (although osal_timer_UT occasionally still fails due to a test issue)
  3. Make cmdUtils where cFS-GroundSystem expects it
    1. cd tools/cFS-GroundSystem/Subsystems/cmdUtil
    2. make
  4. Started Ground system
    1. python3 GroundSystem.py
  5. Enabled commands to 127.0.0.1
  6. Confirmed telemetry packets received
  7. Sent ES and TIME noop commands, confirmed noop message from cFS on Port 1
  8. Sent ES power on reset and observed cFS exit

Expected behavior changes
See related pull requests

System(s) tested on

  • cFS Dev Server 2
  • OS: Ubuntu 18.04
  • Versions: ic-20191230 branches

Additional context
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

jphickey and others added 2 commits November 21, 2019 10:29
@jphickey
Fix #8: Add logic to sample_lib for UT
2264f97 
In order to make a useful library unit test example, the
sample_lib itself needs to perform some more interesting work.

In particular it needs at least one external function call
on which a code path decision is made, such that the example UT
code will have more than one code path to demonstrate.

Additionally, the library should have some internal "global"
structure (like real libs would) that contains its state, that
the UT can also test/query.

Both objectives can be accomplished with a small string buffer
that gets populated with a strncpy() call during init, and
printed with the "process" command.
@skliper
CCB 20191218: Merge #10
da4f56d 
Fix #8 
Reviewed and approved at 2019-12-18 CCB
@skliper skliper merged commit da4f56d into master Jan 9, 2020
@astrogeco astrogeco deleted the ic-20191230 branch March 23, 2020 16:56
@skliper skliper added this to the 1.2.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Add at least one conditional for unit testing
2 participants
@skliper @jphickey