Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #45, Move cmds and utils into separate files #205

Merged

Conversation

thnkslprpt
Copy link
Contributor

Describe the contribution

Testing performed
GitHub CI actions all passing successfully.

Local testing confirms 100% of cFS suite tests passing (incl. Sample App tests) and coverage unaffected.

Prior to changes:
Screenshot 2023-04-17 09 23 08

After changes:
Screenshot 2023-04-17 09 23 47

Expected behavior changes
No change to behavior.
The Sample App now more closely matches the recommended structure/style for cFS apps.

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss @thnkslprpt

/* Output CRC */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void SAMPLE_APP_GetCrc(const char *TableName)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
/* Verify command packet length */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/
bool SAMPLE_APP_VerifyCmdLength(CFE_MSG_Message_t *MsgPtr, size_t ExpectedLength)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
/* This function Process Ground Station Command */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
int32 SAMPLE_APP_Process(const SAMPLE_APP_ProcessCmd_t *Msg)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Oct 26, 2023
@dzbaker dzbaker added CCB:Approved Indicates code approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 30, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 30, 2023
*Combines:*

sample_app v1.3.0-rc4+dev56
ci_lab v2.5.0-rc4+dev51
sch_lab v2.5.0-rc4+dev61

**Includes:**

*sample_app*
- nasa/sample_app#189
- nasa/sample_app#195
- nasa/sample_app#198
- nasa/sample_app#201
- nasa/sample_app#205
- nasa/sample_app#208
- nasa/sample_app#209

*ci_lab*
- nasa/ci_lab#148

*sch_lab*
- nasa/sch_lab#151

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Oct 30, 2023
2 tasks
@dzbaker dzbaker merged commit 6d6b64a into nasa:main Oct 30, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 30, 2023
*Combines:*

sample_app v1.3.0-rc4+dev56
ci_lab v2.5.0-rc4+dev51
sch_lab v2.5.0-rc4+dev61

**Includes:**

*sample_app*
- nasa/sample_app#189
- nasa/sample_app#195
- nasa/sample_app#198
- nasa/sample_app#201
- nasa/sample_app#205
- nasa/sample_app#208
- nasa/sample_app#209

*ci_lab*
- nasa/ci_lab#148

*sch_lab*
- nasa/sch_lab#151

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@thnkslprpt thnkslprpt deleted the fix-45-move-cmds-and-utils-to-separate-files branch October 31, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest refactoring sample_app to more closely match "real" apps.
3 participants