Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample_table.c -- relocate? #70

Closed
CDKnightNASA opened this issue Jun 2, 2020 · 3 comments · Fixed by #73 or #76
Closed

sample_table.c -- relocate? #70

CDKnightNASA opened this issue Jun 2, 2020 · 3 comments · Fixed by #73 or #76
Labels
question Further information is requested

Comments

@CDKnightNASA
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Tables are a component of applications that are expected to be customized by the user. The cFS build process supports this customization (for example, by creating sample_defs/tables/cpu1_sample_table.c). Currently sample_table.c is in fsw/src but everything else in fsw/src is not expected to be customized by the user.

I consider sample_app to be the "style template" for applications, so this should be clear not just for users of the sample_app but for folks who model their code on sample_app.

Describe the solution you'd like
I would like to see a clearer indication that sample_table.c is expected to be customized--whether it be relocated to a different folder (fsw/tables?) or possibly rename it to sample_table.c.sample?

Requester Info
Christopher.D.Knight@nasa.gov

@CDKnightNASA CDKnightNASA added question Further information is requested CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jun 2, 2020
@CDKnightNASA
Copy link
Contributor Author

Would like CCB decision on this, thx.

@jphickey
Copy link
Contributor

jphickey commented Jun 2, 2020

Yes - sample_table is the wrong place, it should be in a separate dir, not in fsw/src, as it is configuration, not code, and it is expected that a mission will customize its content by adding a file in "defs" directory.

Recommend fsw/tables as the pattern for example table files. I believe this is what other apps use.

@astrogeco
Copy link
Contributor

CCB-2020-06-03: APPROVED concept

CDKnightNASA added a commit to CDKnightNASA/sample_app that referenced this issue Jun 3, 2020
@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 5, 2020
astrogeco added a commit that referenced this issue Jun 17, 2020
astrogeco pushed a commit that referenced this issue Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
3 participants