Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply code style #37

Closed
skliper opened this issue Jan 27, 2020 · 1 comment · Fixed by #88, #92 or #93
Closed

Apply code style #37

skliper opened this issue Jan 27, 2020 · 1 comment · Fixed by #88, #92 or #93
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@skliper
Copy link
Contributor

skliper commented Jan 27, 2020

Is your feature request related to a problem? Please describe.
Inconstant style

Describe the solution you'd like
See nasa/ci_lab#30 and nasa/ci_lab#28

Describe alternatives you've considered
N/A

Additional context
N/A

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added enhancement New feature or request good first issue Good for newcomers labels Jan 27, 2020
@skliper skliper modified the milestone: 1.2.0 Jan 27, 2020
skliper added a commit to skliper/sample_app that referenced this issue Aug 21, 2020
@skliper
Fix nasa#37, Apply style
7aaf48c
@skliper skliper changed the title Apply and enforce code style Apply code style Aug 21, 2020
@skliper skliper mentioned this issue Aug 21, 2020
Merged
yammajamma added a commit that referenced this issue Aug 27, 2020
@yammajamma
Merge pull request #88 from skliper/fix37-apply-style
998ab22 
Fix #37, Apply style
yammajamma added a commit that referenced this issue Aug 27, 2020
@yammajamma
Revert "Fix #37, Apply style"
4430db2
@yammajamma yammajamma mentioned this issue Aug 27, 2020
Closed
@astrogeco
Copy link
Contributor

Closed by accidental merge to main. Reopening

@astrogeco astrogeco reopened this Aug 27, 2020
@astrogeco astrogeco linked a pull request Aug 27, 2020 that will close this issue
Fix #37, Apply style #91
Closed
astrogeco added a commit that referenced this issue Aug 27, 2020
@astrogeco
Fix #37, Apply standard code style
0553fc7
@astrogeco astrogeco mentioned this issue Aug 27, 2020
Merged
yammajamma added a commit that referenced this issue Aug 28, 2020
@yammajamma
Merge pull request #92 from nasa/apply-style-again
f0c26b6 
Fix #37, Apply style
@yammajamma yammajamma mentioned this issue Aug 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@skliper @astrogeco