Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #197, Refactor SAMPLE_APP_Init/Process to remove multiple returns #198

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Mar 6, 2023

Checklist

Describe the contribution

The Sample App now exhibits the preferred pattern of cFS more closely - encouraging new users to follow the same guidelines.

A few spelling inconsistencies and spacing issues were rectified as well.

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Tested locally - coverage level unchanged by this PR (testing still misses 4 branches in sample_app as per the main branch).

Expected behavior changes
Behavior unchanged - failures during these 2 functions will fail subsequent checks of == CFE_SUCCESS and fall through to the exit point at the end of the function to return the relevant error code.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.

Contributor Info
Avi Weiss @thnkslprpt

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Oct 26, 2023
@dzbaker dzbaker added CCB:Approved Indicates code approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 26, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 30, 2023
*Combines:*

sample_app v1.3.0-rc4+dev56
ci_lab v2.5.0-rc4+dev51
sch_lab v2.5.0-rc4+dev61

**Includes:**

*sample_app*
- nasa/sample_app#189
- nasa/sample_app#195
- nasa/sample_app#198
- nasa/sample_app#201
- nasa/sample_app#205
- nasa/sample_app#208
- nasa/sample_app#209

*ci_lab*
- nasa/ci_lab#148

*sch_lab*
- nasa/sch_lab#151

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Oct 30, 2023
2 tasks
@dzbaker dzbaker merged commit d5489a9 into nasa:main Oct 30, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 30, 2023
*Combines:*

sample_app v1.3.0-rc4+dev56
ci_lab v2.5.0-rc4+dev51
sch_lab v2.5.0-rc4+dev61

**Includes:**

*sample_app*
- nasa/sample_app#189
- nasa/sample_app#195
- nasa/sample_app#198
- nasa/sample_app#201
- nasa/sample_app#205
- nasa/sample_app#208
- nasa/sample_app#209

*ci_lab*
- nasa/ci_lab#148

*sch_lab*
- nasa/sch_lab#151

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@thnkslprpt thnkslprpt deleted the fix-197-refactor-sample-app-to-remove-multiple-returns branch October 31, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor SAMPLE_APP_Init and SAMPLE_APP_Process to remove multiple returns
3 participants