Fix #790, Return status from OS_ConsoleAPI_Init

[skliper]

Describe the contribution
Fix #790 - now returning status from OS_ConsoleAPI_Init so debug warnings will get reported correctly on errors

Testing performed
Build and executed unit tests, passed (note the OS_ConsoleAPI_Init test does not check status)

Expected behavior changes
Will send debug message on error

System(s) tested on

• Hardware: cFS Dev Server
• OS: Ubuntu 18.04
• Versions: cFS Bundle main + this commit

Additional context
See #791 to add full branch coverage to unit tests w/ return checking

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

[jphickey]

This is fine in general however I just wanted to note there is a chance of unintended consequence where FSW might now entirely fail to start if initializing the OS_printf() subsystem (debug) doesn't work.

Returning the failure status here will ultimately trigger a PSP panic/reset whereas before it would simply run in a degraded state where OS_printf() calls didn't work but other things might.

That being said, if this init fails it probably indicates a real underlying problem that will manifest in other ways, so I don't know if allowing startup to continue in a degraded state is a good thing or not.

[skliper]

Returning the failure status here will ultimately trigger a PSP panic/reset...

Understood but I see that as a separate issue (update error handling to not cause panic/reset for this case if desired), either way this routine should report it's real status and it should get reported via some mechanism.