Fix #606, Resolve cast-align error in VxWorks OS_TaskGetId_Impl #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
astrogeco
added
CCB-20210106
and removed
CCB:Ready
|
CCB 2021-01-06 APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #606 - store taskTCB return in a
void *, then cast toOS_impl_task_internal_record_t *just for the pointer math to avoid a strict alignment compiler errorNote the error was observed with cast-align=strict on Ubuntu 20.04 with ENABLE_UNIT_TESTS=true
Testing performed
Built without the error after fix. Built/ran unit tests on Ubuntu 18.04 and they all passed.
Expected behavior changes
None other than avoid compiler error
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC