Integration Candidate: 2020-06-24 #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that: 1. All stub routines register their arguments in the context, so that the values will be available to hook functions. 2. Ensure that the argument names used in stubs match the name in the prototype/documentation so the value can be retrieved by name.
The pthread_attr_setstacksize() function stipulates that it may fail if the user-supplied stack size is not at least PTHREAD_STACK_MIN and also possibly a multiple of page size. This partially reverts previous PR #508 and adds back rounding up to PTHREAD_STACK_MIN and also adds rounding up to a system page size. However the check for zero stack still remains at the shared level so attempts to create a task with zero stack will still fail. This allows internal helper threads to be created with a default minimum stack size, however.
Fix #522 - SocketOpen stub should set sock_id
Avoids a possible truncation in snprintf call.
Fix #534, adjust UT assert buffer sizes
Should use the loop variable (TGT) not TGTNAME.
Fix #538, correct loop variable for coverage install
Add build number and baseline macros Add codename to version string Add macro for version strings
Resolve #531, Add baseline and build number
Fix #547 - ut_assert doc updates
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Implements message header module such that users can customize or extend as needed. - Separates code for easier selection - Implements consistent getter/setter APIs - Fix nasa#736/nasa#781: MsgId logic no longer overrides bits in init - Fix nasa#529: Get size supports max size - Adds single big endian time implementation, but not selected - Adds msg module to module list - Adds msg module to cppcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #196
Fix #522
Fix #525
Fix #526
Fix #534
Fix #538
Fix #547
Resolve #531
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/108/checks
Expected behavior changes
PR #490 - Changed timer-test to be able to use OS_MAX_TIMERS value on top of the hard-coded NUMBER_OF_TIMERS value. This will allow the test to be functional even if the OS_MAX_TIMERS value is reconfigured.
PR #523 -
OS_SocketOpen()setssock_idand returns a status when successful.PR #527 - Ensures that
PR #528 - Adds back rounding up to PTHREAD_STACK_MIN and also adds rounding up to a system page size. Keeps check for zero stack at the shared level; attempts to create a task with zero stack will fail. Allows internal helper threads to be created with a default minimum stack size.
PR #535 - Avoids a possible truncation in snprintf call. No buffer size/truncation warning when building with optimization enabled.
PR #536 - Added new macros to
osapi-versionto report baseline and build numberPR #539 - The coverage binaries are now correctly installed for CPU1 and CPU2 as opposed to installed twice to CPU2 but not at all for CPU1.
PR #548 - Fixes a typo in ut_assert README and clarifies stub documentation.
System(s) tested on
Ubuntu - CI
Additional context
Part of nasa/cFS#108
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Christopher D. Knight, NASA-ARC
Yasir Khan, Emergent Space Technologies, Inc
Joseph Hickey, Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz, NASA-GSFC