Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Candidate 2020-04-01 #408

Merged
merged 10 commits into from
Apr 9, 2020
Merged

Integration Candidate 2020-04-01 #408

merged 10 commits into from
Apr 9, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Apr 6, 2020 •
edited
Loading

Describe the contribution
Integration Candidate
Fixes #259, #389, #347, and #18

Testing performed
See related PRs
Bundle CI - nasa/cFS#64
Test Log: https://travis-ci.com/github/nasa/cFS/builds/159710339

Expected behavior changes
PR #387 - The more descriptive return value OS_ERR_NAME_NOT_FOUND (instead of OS_FS_ERROR) will now be returned from the following functions (): OS_rmfs, OS_mount, OS_unmount, OS_FS_GetPhysDriveName

PR #394 - No more config warnings reported by Travis-CI

PR #388 - The correct variable values will now be displayed when the test is executed.

PR #386 - Wraps OS_ShMem* prototype and unit test wrapper additions in OSAL_OMIT_DEPRECATED.

System(s) tested on
See PRs
Bundle CI - Ubuntu:Bionic

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC
Daniel Knutsen, NASA-GSFC
Gerardo E. Cruz-Ortiz, NASA-GSFC

dmknutsen and others added 9 commits March 25, 2020 14:42
@dmknutsen
Fixes #259, updated osapi-filesys.c + ut_osfilesys_diskio_test to use…
2a5e9ca 
… desired return values
@skliper
Fix #389, Resolve CI config warnings
29594e1
@dmknutsen
Fixes #347, replace task_1_work with correct variable names
07cd2a3
@skliper
Fix #18, Depreacate OS_ShMem*
592328b
@astrogeco
Merge pull request #386 from skliper/fix18-deprecate-shmem
8f293bd 
Fix #18, Deprecate shared memory APIs
@astrogeco
Merge pull request #388 from dmknutsen/issue_347
3805eca 
Fix #347, replaces task_1_work with correct variable names
@astrogeco
Merge pull request #394 from skliper/fix389-ci-config-warn
897dd00 
Fix #389, Resolve CI config warnings
@astrogeco
Merge pull request #387 from dmknutsen/issue_259
e52f37c 
Fix #259, updated osapi-filesys.c + ut_osfilesys_diskio_tes.ct to use…
@skliper @astrogeco
Fix #385, Deprecate interrupt related APIs (#396)
12499d6 
Removes coverage test code completely
Marks OS_Int* API's as deprecated and implementations
removed if OSAL_OMIT_DEPRECATED defined

Co-authored-by: Gerardo E. Cruz-Ortiz <59618057+astrogeco@users.noreply.github.com>
@astrogeco astrogeco changed the title Integration candidate Integration Candidate 04-01-2020 Apr 6, 2020
@astrogeco astrogeco changed the title Integration Candidate 04-01-2020 Integration Candidate 2020-04-01 Apr 6, 2020
@astrogeco astrogeco changed the title Integration Candidate 2020-04-01 WIP: Integration Candidate 2020-04-01 Apr 6, 2020
This was linked to issues Apr 9, 2020
OSAL headers define a shared memory API that is not actually implemented anywhere #18
Closed
bin-sem-flush-test reporting work incorrectly #347
Closed
Fix travis-CI config warnings #389
Closed
@astrogeco astrogeco mentioned this pull request Apr 9, 2020
Merged
@astrogeco astrogeco changed the title WIP: Integration Candidate 2020-04-01 Integration Candidate 2020-04-01 Apr 9, 2020
@astrogeco astrogeco merged commit 7d9c4c8 into master Apr 9, 2020
@skliper skliper added this to the 5.1.0 milestone Jun 1, 2020
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Fix nasa#408, remove driver reference
c5df6c1
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
@astrogeco
Merge pull request nasa#477 from avan989/new_removeDriver
75558f1 
Fix nasa#408, Remove device driver references in code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bootes
3 participants
@astrogeco @skliper @dmknutsen