Fix #349, OS_SocketAccept() fix #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So did this just never work, and never got tested until now? That's a bit concerning. |
|
CCB 2020-03-25: Approved |
astrogeco
added
the
CCB:Approved
astrogeco
changed the title
astrogeco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #349, note that this does not include unit tests. There don't seem to be any unit tests for the OSAL networking code. We should discuss at the CCB.
Testing performed
Tested with the TCP version of SBN, without the fix it fails on the Accept() call, with the fix, SBN nodes connect and traffic flows as expected.
Expected behavior changes
OS_SocketAccept() should work to accept new incoming TCP connections.
System(s) tested on
64-bit Debian 9 VM.
Additional context
Add any other context about the contribution here.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Christopher.D.Knight@nasa.gov