Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pointer error in OS_GetErrorName #1436

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

ahatstat
Copy link
Contributor

@ahatstat ahatstat commented Dec 14, 2023

Checklist (Please check before submitting)

Describe the contribution
Fixes #1435

Testing performed
Build and run all coverage tests including coverage-shared-errors-testrunner on ARM/Linux and PC/Ubunutu. All tests pass and do not seg fault.

Expected behavior changes
Fewer seg faults when running unit tests

System(s) tested on
ARM9/Embedded Linux
PC/Ubuntu 22.04LTS

Additional context
N/A

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Andrew Hatstat, Geost

@ahatstat ahatstat marked this pull request as ready for review December 19, 2023 15:46
@dzbaker dzbaker requested a review from jphickey January 4, 2024 19:16
@jphickey
Copy link
Contributor

This looks good but I had the question of how it could have been in there for so long and never noticed. We should create a follow-on issue to investigate why this does not fail in our existing workflows

@dzbaker dzbaker added the CCB:Approved Indicates code review and approval by community CCB label Jan 18, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 18, 2024
*Combines:*

ci_lab equuleus-rc1+dev51
cFE equuleus-rc1+dev79
osal equuleus-rc1+dev37

**Includes:**

*ci_lab*
- nasa/ci_lab#162
- nasa/ci_lab#171

*cFE*
- nasa/cFE#2494

*osal*
- nasa/osal#1436

Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com>
Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Jan 18, 2024
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 18, 2024
*Combines:*

ci_lab equuleus-rc1+dev51
cFE equuleus-rc1+dev79
osal equuleus-rc1+dev37

**Includes:**

*ci_lab*
- nasa/ci_lab#162
- nasa/ci_lab#171

*cFE*
- nasa/cFE#2494

*osal*
- nasa/osal#1436

Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com>
Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
@dzbaker dzbaker merged commit 128ab23 into nasa:main Jan 18, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 18, 2024
*Combines:*

ci_lab equuleus-rc1+dev51
cFE equuleus-rc1+dev79
osal equuleus-rc1+dev37

**Includes:**

*ci_lab*
- nasa/ci_lab#162
- nasa/ci_lab#171

*cFE*
- nasa/cFE#2494

*osal*
- nasa/osal#1436

Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com>
Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB Equuleus-rc2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS_GetErrorName Seg Faults
3 participants