osal Integration candidate: Caelum-rc4+dev26 #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the following APIs which are direct reciprocals of the existing time conversion functions: OS_time_t OS_TimeFromTotalSeconds(int64 tm) OS_time_t OS_TimeFromTotalMilliseconds(int64 tm) OS_time_t OS_TimeFromTotalMicroseconds(int64 tm) OS_time_t OS_TimeFromTotalNanoseconds(int64 tm)
Instantiate the condvar lock on rtems and vxworks even though the feature is not currently implemented. This is because OS_MAX_CONDVARS must still be nonzero and if the "Create" function is called, it still goes through the motions of allocating an ID. This also adds a NULL check in the lock implementation, and thus if a lock is not instantiated in the future this will not dereference a NULL pointer.
Adds optional "install" commands to CMake script, which is useful when building OSAL as a standalone software package. The public API and static libraries will be installed to the specified system location, and can then be used to compile and link external OSAL applications without the need for the original OSAL source or build trees. Note this also installs the "osconfig.h" file as this does affect the binary formats of some items (i.e. size of items using OS_MAX_API_NAME and other similar structure members). The external application must be compiled using the same osconfig.h after installation.
Fix #1304, locks for condvar objects on rtems/vxworks
Fix #1307, Add time conversion reciprocal functions
Fix #1284, add export targets and package script
Fix #1305, Stop empty function catching CI workflow format checks
…ine-cleanup Fix #1308, Remove redundant/inconsistent comments (/* end of function */, /* end if */ etc.) and clean up empty lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
cFS Bundle Checks
osal Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 18.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@thnkslprpt