Fix #1023, resolve discrepancies between timer API and unit tests #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
reviewed
May 26, 2021
skliper
approved these changes
May 26, 2021
jphickey
added
the
CCB:Ready
astrogeco
added
the
CCB:Approved
jphickey
force-pushed
the
fix-1023-timer-api-retcodes
branch
from
e3220b0
to
613c801
Compare
Ensures correlation between the test cases and documented return values for the OSAL timer API.
jphickey
force-pushed
the
fix-1023-timer-api-retcodes
branch
from
613c801
to
1e0025b
Compare
|
Re-Pushed to correct commit message typo and squash commits where necessary. This also includes the change requested to reference the function pointer doc, rather than repeating the prototype. |
jphickey
changed the title
astrogeco
added
IC:2021-06-01
and removed
CCB:Ready
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
…ceFail Fix nasa#1052, Refactor UT_ClearForceFail to UT_ClearDefaultReturnValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Ensures correlation between the test cases and documented return values for the OSAL timer API.
Fixes #1023
Testing performed
Build and run unit tests, re-run cross reference script to confirm
Expected behavior changes
All documented return values are tested or noted that they cannot be tested in functional test
System(s) tested on
Ubuntu
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.