Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTEMS fails to build with shell enabled #945

Closed
jphickey opened this issue Apr 6, 2021 · 0 comments · Fixed by #946 or #967
Closed

RTEMS fails to build with shell enabled #945

jphickey opened this issue Apr 6, 2021 · 0 comments · Fixed by #946 or #967
Assignees
@jphickey
Labels
bug
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented Apr 6, 2021

Describe the bug
The prototype for the OS_ShellOutputToFile_Impl() function has gotten stale and needs an update. Unfortunately this isn't built as part of any regularly-run test routine.

To Reproduce
Change OSAL config to enable shell
Build on RTEMS

Expected behavior
Build should pass

Code snips

osal/src/os/rtems/src/os-impl-shell.c

Line 55 in 65c584f

int32 OS_ShellOutputToFile_Impl(uint32 file_id, const char *Cmd)

System observed on:
RTEMS 4.11.3 target, Ubuntu 20.04 host.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Apr 6, 2021
@jphickey jphickey added the bug label Apr 6, 2021
@skliper skliper added this to the 6.0.0 milestone Apr 6, 2021
jphickey added a commit to jphickey/osal that referenced this issue Apr 6, 2021
@jphickey
Fix nasa#945, shell implementation on posix and rtems
f9d571a 
Due to other changes the shell implementation on RTEMS and POSIX failed
to build under certain configurations.  This fixes and verifies the
shell functions as expected.
@skliper skliper linked a pull request Apr 7, 2021 that will close this issue
Fix #945, shell implementation on posix and rtems #946
Merged
jphickey added a commit to jphickey/osal that referenced this issue Apr 7, 2021
@jphickey
Fix nasa#945, shell implementation on posix and rtems
7710202 
Due to other changes the shell implementation on RTEMS and POSIX failed
to build under certain configurations.  This fixes and verifies the
shell functions as expected.
astrogeco added a commit that referenced this issue Apr 21, 2021
@astrogeco
Merge pull request #946 from jphickey/fix-945-rtems-shell
f6eb458 
Fix #945, shell implementation on posix and rtems
This was referenced Apr 21, 2021
Merged
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#945, Finish CFE_PLATFORM_ES_PERF_MAX_IDS removal
21bf38a
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1104 from skliper/fix945-platform_perf_max_id
cc514bc 
Fix nasa#945, Finish CFE_PLATFORM_ES_PERF_MAX_IDS removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper