Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commented out code where it doesn't have a benefit #785

Closed
skliper opened this issue Feb 9, 2021 · 0 comments · Fixed by #786 or #774
Closed

Remove commented out code where it doesn't have a benefit #785

skliper opened this issue Feb 9, 2021 · 0 comments · Fixed by #786 or #774
Labels
docs enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Feb 9, 2021

Is your feature request related to a problem? Please describe.
Pages of commented out code warnings show up in static analysis.

Describe the solution you'd like
General scrub and removal where it's not necessary.

Describe alternatives you've considered
None, any valuable comments will be retained

Additional context
CodeQL warnings

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 6.0.0 milestone Feb 9, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 9, 2021
@skliper
Fix nasa#785, Clean commented out code
58006ae
@skliper skliper mentioned this issue Feb 9, 2021
Merged
@astrogeco astrogeco added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Feb 12, 2021
astrogeco added a commit that referenced this issue Feb 12, 2021
@astrogeco
Merge pull request #786 from skliper/fix785-rm_commented_out_code
e964f1e 
Fix #785, Clean commented out code
@astrogeco astrogeco added the docs label Feb 12, 2021
@astrogeco astrogeco mentioned this issue Feb 12, 2021
Merged
jphickey added a commit to jphickey/osal that referenced this issue Aug 10, 2022
@jphickey
Fix nasa#785, update vxworks 6.9 example toolchain
8993a7e 
Add missing include path to the target/h and wrn/coreip directory.
Set and clarify difference between WIND_HOME and WIND_BASE variables.
Remove unrelated comment about CEXP (remnant from RTEMS).
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#786 from jphickey/fix-785-update-vxworks-tool…
4f49489 
…chain

Fix nasa#785, update vxworks 6.9 example toolchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco