Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build broken for VxWorks on RHEL 7 #697

Closed
jphickey opened this issue Dec 18, 2020 · 0 comments · Fixed by #706 or #750
Closed

Build broken for VxWorks on RHEL 7 #697

jphickey opened this issue Dec 18, 2020 · 0 comments · Fixed by #706 or #750
Labels
bug vxworks
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Describe the bug
The newest RHEL 7 comes by default with CMake version 2.8.12.2 in the official OS repos.
However the "VERSION_GREATER_EQUAL" comparison was added in 3.7. Thus the build became broken on this platform after merging #610.

To Reproduce
Attempt to build for VxWorks using RHEL 7.x as the host platform. Make file generation fails immediately with:

CMake Error at /home/jphickey/cfecfs/github/osal/src/os/vxworks/CMakeLists.txt:48 (if):
  if given arguments:

    "CMAKE_SYSTEM_VERSION" "VERSION_GREATER_EQUAL" "7.0"

  Unknown arguments specified

Expected behavior
Build should succeed.

Code snips

osal/src/os/vxworks/CMakeLists.txt

Line 48 in d698a4d

if (CMAKE_SYSTEM_VERSION VERSION_GREATER_EQUAL 7.0)

System observed on:
Red Hat Enterprise Linux Workstation release 7.9 (Maipo)

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey added the bug label Dec 18, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Dec 18, 2020
@arielswalker
Fix nasa#679, Convert OSAL Config Guide to markdown
d6cb7db 
Fix nasa#697, Fix formatting
jphickey added a commit to jphickey/osal that referenced this issue Dec 18, 2020
@jphickey
Fix nasa#697, use VERSION_LESS instead of VERSION_GREATER_EQUAL
82e6a0a
@jphickey jphickey mentioned this issue Dec 18, 2020
Closed
jphickey added a commit to jphickey/osal that referenced this issue Dec 28, 2020
@jphickey
Fix nasa#697, use POSIX dir implementation on VxWorks6
ed990e7 
Instead of maintaining a one-off implementation for VxWorks 6,
use the POSIX implementation for this module.  The only
incompatibility is the prototype for mkdir() which is missing
the second argument.  This can be worked around with a simple
compatibility macro that is only enabled for VxWorks 6.x builds.
@jphickey jphickey mentioned this issue Dec 28, 2020
Merged
@skliper skliper added this to the 6.0.0 milestone Jan 4, 2021
astrogeco added a commit that referenced this issue Jan 13, 2021
@astrogeco
Merge pull request #706 from jphickey/fix-697-vxworks6-dir
e9ff3a6 
Fix #697, use POSIX dir implementation on VxWorks6
@astrogeco astrogeco mentioned this issue Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug vxworks
Projects
None yet
Milestone
Caelum
3 participants
@jphickey @skliper @astrogeco