Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OS_PACK define #644

Closed
skliper opened this issue Nov 4, 2020 · 0 comments · Fixed by #734 or #750
Closed

Remove OS_PACK define #644

skliper opened this issue Nov 4, 2020 · 0 comments · Fixed by #734 or #750
Labels
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Nov 4, 2020

Is your feature request related to a problem? Please describe.
Shouldn't use non-standard packing options. Really should scrub the list.

/*
** Define compiler specific macros
** The __extension__ compiler pragma is required
** for the uint64 type using GCC with the ANSI C90 standard.
** Other macros can go in here as needed, for example alignment
** pragmas.
**
** NOTE: The white-box (coverage) unit testing may need to disable
** these extra attributes. These test builds define the OSAPI_NO_SPECIAL_ATTRIBS
** macro to disable this.
*/
#if defined(__GNUC__) && !defined(OSAPI_NO_SPECIAL_ATTRIBS)
#define _EXTENSION_ __extension__
#define OS_PACK __attribute__((packed))
#define OS_ALIGN(n) __attribute__((aligned(n)))
#define OS_USED __attribute__((used))
#define OS_PRINTF(n, m) __attribute__((format(printf, n, m)))
#else
#define _EXTENSION_
#define OS_PACK
#define OS_ALIGN(n)
#define OS_USED
#define OS_PRINTF(n, m)
#endif

Describe the solution you'd like
Remove/scrub

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

skliper added a commit to skliper/osal that referenced this issue Jan 4, 2021
@astrogeco astrogeco added bug and removed enhancement labels Jan 13, 2021
astrogeco added a commit that referenced this issue Jan 13, 2021
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey added a commit to jphickey/osal that referenced this issue Aug 10, 2022
The set_directory_properties() function overwrites existing properties.
Normally the properties were empty but the global_build_options.cmake
might make it non-empty (e.g. OMIT_DEPRECATED).

Using set_property() signature instead has an option to APPEND rather
than overwrite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants