Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeBase API missing functional tests #380

Closed
skliper opened this issue Mar 23, 2020 · 5 comments · Fixed by #481 or #487
Closed

TimeBase API missing functional tests #380

skliper opened this issue Mar 23, 2020 · 5 comments · Fixed by #481 or #487
Assignees
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Mar 23, 2020

Is your feature request related to a problem? Please describe.
OS_TimeBaseCreate, OS_TimeBaseSet, OS_TimeBaseDelete, OS_TimeBaseGetIdByName, OS_TimeBaseGetInfo, OS_TimeBaseGetFreeRun all missing functional tests

Describe the solution you'd like
Add tests

Describe alternatives you've considered
None

Additional context
Certification Issue

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 5.1.0 milestone Mar 23, 2020
@CDKnightNASA CDKnightNASA added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Mar 27, 2020
@yammajamma
Copy link
Contributor

I can take this.

@jphickey
Copy link
Contributor

Note that a time base object exists primarily to underpin the timer objects, and they aren't used directly by apps. Therefore API is used and invoked, either directly or indirectly, as part of the existing timer tests. I'm also not sure how you could even test it in isolation, because these objects aren't used directly. Aside from simply creating/deleting the objIDs and just confirming this works?

@skliper
Copy link
Contributor Author

skliper commented May 14, 2020

It's basically to meet the formal test requirements for certification, test full parameter ranges, etc.

@jphickey
Copy link
Contributor

Yeah, most of that parameter checking is already in the coverage test, but could be done again in a full-stack/non-stub enviornment.

I guess the other thing is to confirm you can create e.g. up to OS_MAX_TIMEBASES objects and the +1 one fails, and also that you can delete them successfully too?

@skliper
Copy link
Contributor Author

skliper commented May 14, 2020

Yes please (create all, delete all)! Note we don't get to take verification credit from a coverage test. So the parameter checking needs to be done in the functional test.

yammajamma added a commit to yammajamma/osal that referenced this issue May 21, 2020
yammajamma added a commit to yammajamma/osal that referenced this issue Jun 1, 2020
astrogeco added a commit that referenced this issue Jun 8, 2020
…ional-Tests

Fix #380, Add OS_TimeBase Api Functional Tests
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022


Fixes nasa#379, Fixes nasa#380, Fixes nasa#383, Fixes nasa#384,
Fixes nasa#385, Fixes nasa#392
Code reviewed and approved at 20191106 and 20191113 CB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
4 participants