Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove classic build artifacts #339

Closed
skliper opened this issue Jan 2, 2020 · 3 comments · Fixed by #345
Closed

Remove classic build artifacts #339

skliper opened this issue Jan 2, 2020 · 3 comments · Fixed by #345
Assignees
@avan989
Labels
enhancement
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Jan 2, 2020

Is your feature request related to a problem? Please describe.
Classic build no longer supported.

Describe the solution you'd like
Remove all associated artifacts: build directory, all *.mak directories, setvars.sh

Describe alternatives you've considered
None

Additional context
Makes #164 obsolete

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 5.1.0 milestone Jan 2, 2020
@skliper skliper mentioned this issue Jan 2, 2020
Closed
@avan989
Copy link
Contributor

avan989 commented Jan 8, 2020

I can do this.

@jphickey jphickey mentioned this issue Jan 15, 2020
Closed
skliper added a commit that referenced this issue Jan 21, 2020
@skliper
Merge pull request #345 from avan989/remove_classic_build
b72031b 
Fix #339, Remove classic build
@CDKnightNASA
Copy link
Contributor

Build instructions in doc/OSAL-Configuration-Guide.doc and .pdf have instructions for classic build. Also the section on building the unit tests requires use of the classic build. A new section needs to be written for building unit tests under cmake and the old classic build section needs to be removed (and refs to the classic build in the cmake section need to be stricken.)

@CDKnightNASA CDKnightNASA reopened this Mar 25, 2020
@skliper skliper mentioned this issue Mar 25, 2020
Closed
@skliper
Copy link
Contributor Author

skliper commented Mar 25, 2020

Preference is to open a new issue, see #384

@skliper skliper closed this as completed Mar 25, 2020
@skliper skliper linked a pull request Mar 25, 2020 that will close this issue
Fix #339, Remove classic build #345
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avan989 avan989

Labels
enhancement
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #339, Remove classic build
4 participants
@avan989 @CDKnightNASA @skliper and others