Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move OS_FS_ERR_* defines to common os error definitions #262

Closed
skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #423 or #440
Closed

Move OS_FS_ERR_* defines to common os error definitions #262

skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #423 or #440
Assignees
@dmknutsen
Labels
enhancement
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

OS_DirectoryOpen returns OS_INVALID_POINTER if dir_id or path pointers are NULL.

OS_DirectoryRead returns OS_FS_ERR_INVALID_POINTER if dirent pointer is NULL.

Likely other cases of mixed use. Suggest deprecation of the OS_FS_ERR_* defines and switch to common definitions.
@skliper skliper added this to the osal-5.0.1 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 239. Created by jhageman on 2019-08-23T14:59:31, last modified: 2019-08-23T14:59:31

@skliper skliper added the bug label Sep 30, 2019
@skliper skliper modified the milestones: osal-5.0.1, osal-5.1.0 Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
@skliper skliper added enhancement and removed bug labels Oct 16, 2019
@skliper
Copy link
Contributor Author

skliper commented Oct 22, 2019

Related to #118. Really should deprecate the OS_FS_* defines that aren't unique to FS.

@skliper skliper mentioned this issue Oct 22, 2019
Closed
@dmknutsen dmknutsen self-assigned this Apr 17, 2020
@dmknutsen dmknutsen mentioned this issue Apr 17, 2020
Closed
dmknutsen added a commit to dmknutsen/osal that referenced this issue Apr 17, 2020
@dmknutsen
Fix nasa#262, Deprecates OS_FS_* defines that aren't unique to FS
9ce8887
dmknutsen added a commit to dmknutsen/osal that referenced this issue Apr 17, 2020
@dmknutsen
Fix nasa#262, Removes OS_FS_* defines that aren't unique to FS
9f03211
@dmknutsen dmknutsen mentioned this issue Apr 17, 2020
Closed
dmknutsen added a commit to dmknutsen/osal that referenced this issue Apr 20, 2020
@dmknutsen
Fix nasa#262, Deprecates OS_FS_* defines that aren't unique to FS
78f4aba
@ejtimmon
Copy link

A handful of apps use OS_FS_SUCCESS and/or OS_FS_ERROR.

skliper pushed a commit to dmknutsen/osal that referenced this issue Apr 21, 2020
@dmknutsen @skliper
Fix nasa#262, Deprecates OS_FS_* defines that aren't unique to FS
789902e
skliper pushed a commit to skliper/osal that referenced this issue Apr 28, 2020
@dmknutsen @skliper
Fix nasa#262, Deprecates OS_FS_* defines that aren't unique to FS
41862fd
@skliper skliper linked a pull request Apr 28, 2020 that will close this issue
Fix #344, Consistent directory entry size limit #423
Merged
@skliper skliper mentioned this issue Apr 28, 2020
Merged
@astrogeco astrogeco mentioned this issue Apr 30, 2020
Merged
astrogeco pushed a commit that referenced this issue May 1, 2020
@dmknutsen
Fix #262, Deprecates OS_FS_* defines that aren't unique to FS
4bec2fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmknutsen dmknutsen

Labels
enhancement
Projects
None yet
Milestone
Bootes
3 participants
@ejtimmon @skliper @dmknutsen